From: Sven Verdoolaege Date: Thu, 24 May 2007 13:29:09 GMT Subject: Re: [PATCH 09/15] entry.c: optionally checkout submodules Message-ID: <20070524132909.GR942MdfPADPa@greensroom.kotnet.org> In-Reply-To: <20070520211850.GJ5412@admingilde.org> On Sun, May 20, 2007 at 11:18:50PM +0200, Martin Waitz wrote: > hoi :) > > have you seen my patch to checkout submodules? > > The submodule checkout should really check that the requested commit > is really available and have some other path for creating submodules > which are not currently checked out / able to be checked out. If you are talking about your May 5th patch, then you weren't doing that either. You just checked if it _looked_ like a SHA1. I check for the presence of the commit by calling git-cat-file. Of course, this doesn't guarantee that the whole tree is available. skimo