From: Shawn O. Pearce <spearce@spearce.org>
Date: Tue, 22 May 2007 06:17:32 GMT
Subject: Re: [PATCH] Cross-reference the manpages for git-name-rev and git-describe
Message-ID: <20070522061732.GC11636@spearce.org>
In-Reply-To: <7vhcq59yiy.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > Teach git-describe how to run name-rev
> 
> Sorry for a belated question, but is there a reason not to do
> this (on top)?

Nope, I just completely missed it.  Please make it so!  ;-)
 
> diff --git a/builtin-describe.c b/builtin-describe.c
> index efbd43f..2a32af6 100644
> --- a/builtin-describe.c
> +++ b/builtin-describe.c
> @@ -283,8 +283,7 @@ int cmd_describe(int argc, const char **argv, const char *prefix)
>  		nr[2] = "--tags";
>  		memcpy(nr + 3, argv + i, (argc - i) * sizeof(char*));
>  		nr[3 + argc - i] = NULL;
> -		execv_git_cmd(nr);
> -		die("unable to start %s", nr[0]);
> +		return cmd_name_rev(3 + argc - i, nr, prefix);
>  	}
>  
>  	if (argc <= i)
> 

-- 
Shawn.