From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Mon, 21 May 2007 05:27:23 GMT
Subject: Re: git log -S problem
Message-ID: <200705210727.23898.johannes.sixt@telecom.at>
In-Reply-To: <7vy7jjjjdm.fsf@assigned-by-dhcp.cox.net>

On Sunday 20 May 2007 23:05, Junio C Hamano wrote:
> Johannes Sixt <johannes.sixt@telecom.at> writes:
> > I had expected that the set of commits found by the second search string
> > are a proper superset of those found by the first one. What's wrong here?
> > Why does a search for 'merge-base' not find occurences of
> > 'builtin-merge-base'?
>
> 71dfbf224 removes one line that has "git-merge-base$X" and adds
> one line that has "builtin-merge-base.o".  If you count the
> number of occurences of substring "builtin-merge-base" in the
> preimage and the postimage, you see one addition.  If you count
> the same for substring "merge-base", the net difference is 0.

But is this how -S is *designed* to work? 

Hm, the documentation says (diff-options.txt):

-S<string>::
	Look for differences that contain the change in <string>.

which can be interpreted both to match my expectations as well as the current 
implementation.

-- Hannes