From: Sven Verdoolaege <skimo@kotnet.org>
Date: Fri, 18 May 2007 22:03:23 GMT
Subject: Re: [PATCH 09/16] entry.c: optionally checkout submodules
Message-ID: <20070518220323.GL942MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <20070518215642.GC10475@steel.home>

On Fri, May 18, 2007 at 11:56:42PM +0200, Alex Riesen wrote:
> skimo@liacs.nl, Fri, May 18, 2007 21:24:58 +0200:
> > +	if (err)
> > +		return error("failed to run git-checkout in submodule '%s'", path);
> 
> We may need an option to ignore these failures. Maybe even active by
> default. Imagine a superproject with _optional_ submodules, where it
> is just nice to know that some submodules weren't checked out. BTW,
> doesn't git-checkout already prints an error?

Probably.  You probably noticed that I haven't written any tests yet...

Still, the error that git-checkout prints may not give enough of a clue
that something was wrong with a submodule.

skimo