From: Peter Oberndorfer <kumbayo84@arcor.de>
Date: Tue, 15 May 2007 16:21:08 GMT
Subject: Re: [StGIT PATCH] Don't use patches/<branch>/current
Message-ID: <200705151821.08568.kumbayo84@arcor.de>
In-Reply-To: <b0943d9e0705150856n771cb696h6e8225a0bbd5d43d@mail.gmail.com>

On Tuesday 15 May 2007 17:56, Catalin Marinas wrote:
> On 06/05/07, Karl Hasselström <kha@treskal.com> wrote:
> > The name of the current patch, if any, is always the last line of
> > patches/<branch>/applied (and there is no current patch if and only if
> > the "applied" file is empty). So use that instead, and stop having to
> > worry about keeping the redundant "current" file up-to-date.
> 
> I applied this patch. Could you also send me a patch for the
> bash-completion script as it uses this file?
> 
> I think the self.__current_file (same for the base file removed in a
> different patch) should still be available in the Series object and
> removed when deleting a branch, otherwise you get a "Series directory
> ... is not empty" exception.
> 
> Thanks.
> 
Hi,
this is a bit OT,
but when i wanted to try out this changes i found that 2 unrelated patches in you repo[1] are empty.
* Store branch description in the config file 
* Make the "name" argument to "stg new" optional

Is that a problem on my side, or are they really empty?

Greetings Peter

[1] http://homepage.ntlworld.com/cmarinas/stgit.git
which is mirrored at
http://repo.or.cz/w/stgit.git