From: Frank Lichtenheld <frank@lichtenheld.de>
Date: Mon, 14 May 2007 12:59:16 GMT
Subject: Re: [PATCH (amend)] cvsserver: Add test cases for config file handling
Message-ID: <20070514125915.GB5272@planck.djpig.de>
In-Reply-To: <7vtzugqym8.fsf@assigned-by-dhcp.cox.net>

On Sun, May 13, 2007 at 01:04:15PM -0700, Junio C Hamano wrote:
> Frank Lichtenheld <frank@lichtenheld.de> writes:
> 
> > Add a few test cases for the config file parsing
> > done by git-cvsserver.
> >
> > Signed-off-by: Frank Lichtenheld <frank@lichtenheld.de>
> > ---
> >  t/t9420-git-cvsserver-config.sh |  109 +++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 109 insertions(+), 0 deletions(-)
> >  create mode 100755 t/t9420-git-cvsserver-config.sh
> 
> Do we really need a separate test script that does quite similar setup?

Right now, probably not.

But I certainly don't intend to do all the tests in one big file which
will become rather large over time. If you're concerned with code
duplication, maybe I should move the code to a separate file and source
it from there?

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/