From: Frank Lichtenheld <frank@lichtenheld.de>
Date: Sat, 12 May 2007 16:28:20 GMT
Subject: Re: [PATCH] t9400: Use the repository config and nothing else.
Message-ID: <20070512162819.GA7184@planck.djpig.de>
In-Reply-To: <7v8xbvj5mx.fsf@arte.twinsun.com>

On Fri, May 11, 2007 at 04:35:18PM -0700, Junio Hamano wrote:
> This needs to be fixed, but thanks to that bug, a separate bug
> in t9400 test script was discovered.  The test discarded
> GIT_CONFIG instead of pointing at the proper one to be used in
> the exoprted repository.  This allowed user's .gitconfig and (if
> exists) systemwide /etc/gitconfig to affect the outcome of the
> test, which is a big no-no.

Shouldn't you also remove the "unset GIT_CONFIG" then?

> @@ -26,6 +26,7 @@ perl -e 'use DBI; use DBD::SQLite' >/dev/null 2>&1 || {
>  unset GIT_DIR GIT_CONFIG
>  WORKDIR=$(pwd)
>  SERVERDIR=$(pwd)/gitcvs.git
> +git_config=$SERVERDIR/config
>  CVSROOT=":fork:$SERVERDIR"
>  CVSWORK=$(pwd)/cvswork

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/