From: Frank Lichtenheld <frank@lichtenheld.de>
Date: Wed, 09 May 2007 20:27:20 GMT
Subject: Re: failing test t9400 (Re: [PATCH] git-update-ref: add --no-deref option for overwriting/detaching ref)
Message-ID: <20070509202720.GN30324@planck.djpig.de>
In-Reply-To: <7vr6pqt1fu.fsf@assigned-by-dhcp.cox.net>

On Wed, May 09, 2007 at 09:19:01AM -0700, Junio C Hamano wrote:
> Sven Verdoolaege <skimo@kotnet.org> writes:
> > Shouldn't these tests be skipped if I don't have all that stuff installed?
> > There doesn't even seem to be an option to turn off these tests.
> 
> I agree.  We would need something like this, but I have no easy
> way to test it myself, short of uninstalling what I need on the
> box.  As you do not have them, maybe you can give it a quick
> whirl?

Yeah, I totally forgot add such a check, even though I added one for
cvs.

> ---
> diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh
> index f17be6b..98d6bb4 100755
> --- a/t/t9400-git-cvsserver-server.sh
> +++ b/t/t9400-git-cvsserver-server.sh
> @@ -17,6 +17,11 @@ then
>      test_done
>      exit
>  fi
> +perl -e 'use DBI; use DBD::SQLite' 2>&1 || {

Maybe there is a >/dev/null missing here?

I personally would prefer "perl -MDBI -MDBD::SQLite" stylewise, but I
guess it makes no difference in the end.

> +    test_expect_success 'skipping git-cvsserver tests, Perl SQLite interface unavailable' :
> +    test_done
> +    exit
> +}

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/