From: Karl Hasselström Date: Sun, 06 May 2007 10:19:53 GMT Subject: Re: FFmpeg considering GIT Message-ID: <20070506101953.GA17498@diana.vm.bytemark.co.uk> In-Reply-To: On 2007-05-05 10:26:12 -0700, Linus Torvalds wrote: > The "-S" thing doesn't really interact well with "gitk", because it > doesn't rewrite the parent information (it is basically just a "hide > commits that don't pass this criteria"). As such, gitk, which > requires parent information to generate the graph, is not very > amenable to using "-S" and such. > > That said, you can apply this fairly trivial patch to "gitk" to make > it parse the output of "git log" rather than "git rev-list", and > that will actually get you working -S'xyz' parsing automatically. > It's just that the commit history window will look like crap. OK, now I've tested it, and just as you said, it works (and is _very_ useful) but looks like crap. :-) Is there any fundamental reason why gitk -- some/path/name generates a nice, connected graph, while gitk -S'some string' generates disconnected spaghetti? Or could the latter be made to use the same parent-rewriting logic as the first? -- Karl Hasselström, kha@treskal.com www.treskal.com/kalle