From: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Date: Thu, 03 May 2007 07:03:02 GMT
Subject: Re: [PATCH] Documentation: "bisect run" can be given bangs before the run script.
Message-ID: <20070503070302.GA4491@informatik.uni-freiburg.de>
In-Reply-To: <7vmz0m3261.fsf@assigned-by-dhcp.cox.net>

Hello,

Junio C Hamano wrote:
> I am not convinced that '!' is a good extension for two and half
> reasons.
> 
>  * The expected use is not quite clear.  If it is not used to
>    run a custom test script but something stock as "make", by
>    the nature of UNIX exit status convention, you are looking
>    for the commit that _fixed_ some breakage (i.e. "which commit
>    fixed the compilation error?").  While sometimes that is a
>    useful thing to do, it feels somewhat of limited value.
> 
>    On the other hand, if you are running a custom test script, I
>    do not think it is unreasonable to always require that a test
>    script to signal "bad" with small non-zero, "good" with zero,
>    and error with high non-zero status, as we already do.
> 
>  * How should this interact with the "high non-zero status means
>    an error and we cannot bisect" return convention?
> 
>  * I was hoping that we can officially support "don't know,
>    cannot test this one, please give me another" for interactive
>    use, and at the same time allow the run-script used by
>    "git bisect run" to signal such with a special exit value
>    (perhaps "exit 42").  Taken together with the previous point,
>    it is not clear how '!' should interact with such an
>    enhancement.
Ack for all 2½ reasons.

Uwe

-- 
Uwe Kleine-König

http://www.google.com/search?q=1+newton+in+kg*m+%2F+s%5E2