From: Alex Riesen Date: Mon, 30 Apr 2007 22:22:53 GMT Subject: [PATCH] Use strlcpy instead of strncpy in mailmap.c Message-ID: <20070430222253.GA5000@steel.home> strncpy does not NUL-terminate output in case of output buffer too short, and map_email prototype (and usage) does not allow for figuring out what the length of the name is. Signed-off-by: Alex Riesen --- mailmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mailmap.c b/mailmap.c index af187a3..c29e4e5 100644 --- a/mailmap.c +++ b/mailmap.c @@ -80,7 +80,7 @@ int map_email(struct path_list *map, const char *email, char *name, int maxlen) free(mailbuf); if (item != NULL) { const char *realname = (const char *)item->util; - strncpy(name, realname, maxlen); + strlcpy(name, realname, maxlen); return 1; } return 0; -- 1.5.2.rc0.792.g7f4bd0