From: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
Date: Fri, 27 Apr 2007 21:13:26 GMT
Subject: Re: [PATCH 1/5] Introduces for_each_revision() helper
Message-ID: <20070427181326.14bbbf5c@localhost>
In-Reply-To: <7vabwtobpg.fsf@assigned-by-dhcp.cox.net>

Em Fri, 27 Apr 2007 12:32:11 -0700
Junio C Hamano <junkio@cox.net> escreveu:

| "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
| writes:
| 
| > From: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
| >
| > This macro may be used to iterate over revisions, so, instead of
| > doing: ...
| 
| I am not a big fan of magic control-flow macros, as it makes the
| code harder to grok for people new to the codebase.

 Yeah, I agree. But I think that any experienced programmer will
understand it.

 Anyways, I don't want to raise polemic discussions for minor
changes. Feel free to drop this one then.

-- 
Luiz Fernando N. Capitulino