From: Alex Riesen <raa.lkml@gmail.com>
Date: Sat, 21 Apr 2007 20:02:39 GMT
Subject: Re: [PATCH 1/4] add mode parameter to get_sha1
Message-ID: <20070421200239.GA2437@steel.home>
In-Reply-To: <1177158380197-git-send-email-mkoegler@auto.tuwien.ac.at>

Martin Koegler, Sat, Apr 21, 2007 14:26:17 +0200:
> If the mode parameter is not NULL, get_sha1 will store
> the mode of the object in it.

It looks like the number of call sites which actually use the
argument is vanishingly small compared to the number of sites
where it is set to NULL. Why don't you introduce a new function
instead, say get_sha1_and_mode, and use it for this two or three
places?