From: Frank Lichtenheld <frank@lichtenheld.de>
Date: Tue, 10 Apr 2007 08:40:23 GMT
Subject: Re: [PATCH 6/6] Teach core object handling functions about gitlinks
Message-ID: <20070410084022.GB2813@planck.djpig.de>
In-Reply-To: <Pine.LNX.4.64.0704092115350.6730@woody.linux-foundation.org>

On Mon, Apr 09, 2007 at 09:20:29PM -0700, Linus Torvalds wrote:
> diff --git a/sha1_file.c b/sha1_file.c
> index 4304fe9..ab915fa 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -13,6 +13,7 @@
>  #include "commit.h"
>  #include "tag.h"
>  #include "tree.h"
> +#include "refs.h"
>  
>  #ifndef O_NOATIME
>  #if defined(__linux__) && (defined(__i386__) || defined(__PPC__))
> @@ -2332,6 +2333,8 @@ int index_path(unsigned char *sha1, const char *path, struct stat *st, int write
>  				     path);
>  		free(target);
>  		break;
> +	case S_IFDIR:
> +		return resolve_gitlink_ref(path, "HEAD", sha1);
>  	default:
>  		return error("%s: unsupported file type", path);
>  	}

Not that I have time right now to look up the exact context (only read
the patch), but I would've expected a "case S_IFDIRLNK:" here?

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/