From: Jeff King <peff@peff.net>
Date: Wed, 28 Mar 2007 22:17:54 GMT
Subject: Re: [PATCH] --pretty=format: print fewer <unknown>s
Message-ID: <20070328221754.GB25430@coredump.intra.peff.net>
In-Reply-To: <7v3b3pf245.fsf@assigned-by-dhcp.cox.net>

On Wed, Mar 28, 2007 at 03:13:30PM -0700, Junio C Hamano wrote:

> > This makes empty bodies truly empty, and fills in the
> > default UTF-8 encoding for an empty encoding.
> 
> I do not think the latter is correct.  Replacing with an empty
> string might make sense, although I haven't thought through the
> issues.

Fair enough. I originally put in an empty string, but tried to be (too)
clever with UTF-8 (I was under the impression that commits without
headers were assumed to be in UTF-8, unless there is some legacy
override set). I'm fine with whatever makes sense, but I think printing
<unknown> is silly: we _do_ know.

-Peff