From: Alex Riesen Date: Sun, 25 Mar 2007 09:33:45 GMT Subject: Re: [PATCH] Use diff* with --exit-code in git-am, git-rebase and git-merge-ours Message-ID: <20070325093345.GA2563@steel.home> In-Reply-To: <7vwt15c150.fsf@assigned-by-dhcp.cox.net> Junio C Hamano, Sun, Mar 25, 2007 08:01:31 +0200: > However, I have a few comments. > > Have you run any benchmark? I suspect "and speeds things up" is I didn't benchmark any of these, so I can't backup the statement with the number but... > a gross overstatement. A qualified "SOMETIMES speeds things up" > would be a more honest thing to say. it must speed things up, if only for removed shell-side efforts to redirect the output and store it in heap. To overstatement it I should have said: "greatly speeds things up".