From: Shawn O. Pearce Date: Tue, 13 Mar 2007 00:56:21 GMT Subject: Re: [PATCH 4/4] Replace fork_with_pipe in bundle with run_command Message-ID: <20070313005621.GA17243@spearce.org> In-Reply-To: <7v3b4aotd9.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > "Shawn O. Pearce" writes: > > > Junio C Hamano wrote: > >> "Shawn O. Pearce" writes: > >> > return status; > >> > >> As the variable 'status' is not used anymore, I think this should return 0. > > > > Indeed. I replaced that patch with another (same subject) in my > > latest series. Because leaving that 'status' variable in caused > > a failure in the test suite when trying to create a bundle. > > > > fixed: http://article.gmane.org/gmane.comp.version-control.git/42087 > > borked: http://article.gmane.org/gmane.comp.version-control.git/42056 > > > > You quoted the borked one. Please drop it and apply the fixed one. > > Ok, diffing these two the only differences I see are identical > to what I locally hand-fixed, so we are Ok it seems. Yes, the only difference between the two patches was the unused 'status' variable, and returning 0 when we did actually make the bundle successfully. ;-) Sorry for the pain today. I usually try harder to avoid problems like this... -- Shawn.