From: Shawn O. Pearce Date: Mon, 12 Mar 2007 19:13:13 GMT Subject: Re: [PATCH] fast-import: use binary search in tree_content_remove Message-ID: <20070312191313.GC15887@spearce.org> In-Reply-To: <20070311163412.GB7110@coredump.intra.peff.net> Jeff King wrote: > And here is a test that I believe triggers the problem (fails with my > patches, succeeds with your fix): Thanks, this is a good test to have. Since the current "stable" version passes without your patches I'm applying the test first; that way we can see if/when a change breaks this ordering requirement and address it immediately in that patch. > > I'm plastering over the problem by resorting a tree strictly by > > name after it has been written out and the deleted entries have > > been filtered out. > > I wonder if we could make this a bit cleaner by actually using the git > sort in the first place. I will take a look... Good luck. I'm not sure its easily done. Which is why I'm not attempting to do it right now. -- Shawn.