From: Jeff King <peff@peff.net>
Date: Sun, 11 Mar 2007 16:54:32 GMT
Subject: Re: [PATCH] fast-import: use binary search in tree_content_remove
Message-ID: <20070311165432.GA13555@coredump.intra.peff.net>
In-Reply-To: <20070311163412.GB7110@coredump.intra.peff.net>

On Sun, Mar 11, 2007 at 12:34:13PM -0400, Jeff King wrote:

> > I'm plastering over the problem by resorting a tree strictly by
> > name after it has been written out and the deleted entries have
> > been filtered out.
> I wonder if we could make this a bit cleaner by actually using the git
> sort in the first place. I will take a look...

Hrm, it's not that hard to pass the mode around and use
base_name_compare, but I don't think that's enough. Any time we turn an
entry into a tree, we'll have to resort. I think your patch is simpler
and less error prone.

-Peff