From: Jeff King Date: Sun, 11 Mar 2007 15:59:55 GMT Subject: Re: [PATCH 2/3] fast-import: tree allocation cleanups Message-ID: <20070311155955.GA7586@coredump.intra.peff.net> In-Reply-To: <20070311155138.GA7110@coredump.intra.peff.net> On Sun, Mar 11, 2007 at 11:51:38AM -0400, Jeff King wrote: > OK. There are actually two changes: moving the insertion until after > e->name is set up (which has no functionality impact) and changing the > manner of insertion. I split them up to try to make them more readable, > but clearly you figured out what I was going for. BTW, the commit message for your d4239be9 is now inaccurate (you moved the hunk for my point "1" to the next patch). Probably not worth fixing, but I thought I would mention it. -Peff