From: Matthias Lederhofer Date: Sun, 11 Mar 2007 01:35:00 GMT Subject: [PATCH] setup_git_directory_gently: fix off-by-one error Message-ID: <20070311013459.GA30057@moooo.ath.cx> don't tell getcwd that the buffer has one spare byte for an extra / Signed-off-by: Matthias Lederhofer --- gdb session with PATH_MAX set to 2048: Breakpoint 5, setup_git_directory_gently (nongit_ok=0x0) at setup.c:253 253 cwd[len] = 0; $ print sizeof(cwd) $14 = 2049 $ print len $15 = 2049 $ print PATH_MAX $16 = 2048 --- setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/setup.c b/setup.c index dda67d2..a45ea83 100644 --- a/setup.c +++ b/setup.c @@ -216,7 +216,7 @@ const char *setup_git_directory_gently(int *nongit_ok) die("Not a git repository: '%s'", gitdirenv); } - if (!getcwd(cwd, sizeof(cwd)) || cwd[0] != '/') + if (!getcwd(cwd, sizeof(cwd)-1) || cwd[0] != '/') die("Unable to read current working directory"); offset = len = strlen(cwd); -- 1.5.0.3