From: Karl Hasselström <kha@treskal.com>
Date: Thu, 08 Mar 2007 06:45:34 GMT
Subject: Re: [PATCH 5/6] Fix some "comparison is always true/false" warnings.
Message-ID: <20070308064534.GA5981@diana.vm.bytemark.co.uk>
In-Reply-To: <45EF0D0D.4060904@ramsay1.demon.co.uk>

On 2007-03-07 19:05:49 +0000, Ramsay Jones wrote:

> Karl Hasselström wrote:
>
> > Umm ... wouldn't an uint32_t be a better fit here?
>
> Yes, but I did not want to add a dependency on a C99 header (i.e.
> <stdint.h>). I had a vague recollection that Linus had stated that
> git was probably broken if int wasn't 32 bits, so ...
>
> This was before I realized that a recent change to git meant that
> git was already including C99 headers <inttypes.h> and, therefore
> indirectly, <stdint.h>.

Your approach is much more sophisticated than mine. :-) I just
thought, "wow, this _screams_ for a uint32_t -- hmm, is it OK to use
that?", and then did "git grep uint32_t" and got about a screenful of
hits.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle