From: Johannes Sixt Date: Fri, 02 Mar 2007 22:05:13 GMT Subject: Re: [PATCH] Add core.symlinks to mark filesystems that do not support symbolic links. Message-ID: <200703022305.14058.johannes.sixt@telecom.at> In-Reply-To: On Friday 02 March 2007 22:35, Johannes Schindelin wrote: > On Fri, 2 Mar 2007, Johannes Sixt wrote: > > diff --git a/cache.h b/cache.h > > index 04f8e63..6f932fe 100644 > > --- a/cache.h > > +++ b/cache.h > > @@ -108,7 +108,10 @@ static inline unsigned int create_ce_mode(unsigned > > int mode) } > > static inline unsigned int ce_mode_from_stat(struct cache_entry *ce, > > unsigned int mode) { > > - extern int trust_executable_bit; > > + extern int trust_executable_bit, has_symlinks; > > Would it not be better to move the global variables before this function? I'd move the whole function out-of-line, I just wouldn't know whereto... -- Hannes