From: Shawn O. Pearce <spearce@spearce.org>
Date: Thu, 01 Mar 2007 03:59:10 GMT
Subject: Re: [EGIT PATCH 6/9] Add branch and StGit patch to decorator
Message-ID: <20070301035909.GA8103@spearce.org>
In-Reply-To: <20070228222637.12021.63285.stgit@lathund.dewire.com>

Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> +	public String getPatch() throws IOException {
> +		final File ptr = new File(getDirectory(),"patches/"+getBranch()+"/current");
> +		final BufferedReader br = new BufferedReader(new FileReader(ptr));
> +		final String line = br.readLine();
> +		return line;
> +	}

Last time I checked leaking a file descriptor was a bad idea.
I fixed it (in both methods) when I applied the patch.

Your whole series is now pushed. Thanks for the cleanups.

-- 
Shawn.