From: Shawn O. Pearce Date: Tue, 27 Feb 2007 15:01:26 GMT Subject: Re: [PATCH 5/6] convert object type handling from a string to a number Message-ID: <20070227150126.GA3230@spearce.org> In-Reply-To: <7vejobhor2.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > I am wondering if "enum object_type" and signed comparison here > are compatible. sha1_object_info() is of type "int" so that is > clearly signed, but are we safe assuming this would not result > in "type is unsigned and condition is always false"? See my recent patch; I actually rewrote those hunks to use OBJ_BAD rather than < 0, as this cleans things up for my packv4. -- Shawn.