From: Andy Parkins Date: Tue, 27 Feb 2007 12:49:09 GMT Subject: [PATCH 2/2] cvsserver: Remove trailing "\n" from commithash in checkin function Message-ID: <200702271249.09596.andyparkins@gmail.com> In-Reply-To: <200702210908.59579.andyparkins@gmail.com> The commithash for updating the ref is obtained from a call to git-commit-tree. However, it was returned (and stored) with the trailing newline. This meant that the later call to git-update-ref that was trying to update to $commithash was including the newline in the parameter - obviously that hash would never exist, and so git-update-ref would always fail. The solution is to chomp() the commithash as soon as it is returned by git-commit-tree. Signed-off-by: Andy Parkins --- git-cvsserver.perl | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-cvsserver.perl b/git-cvsserver.perl index 8e12f81..f4b8bd2 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -1152,6 +1152,7 @@ sub req_ci close $msg_fh; my $commithash = `git-commit-tree $treehash -p $parenthash < $msg_filename`; + chomp($commithash); $log->info("Commit hash : $commithash"); unless ( $commithash =~ /[a-zA-Z0-9]{40}/ ) -- 1.5.0.2.778.gdcb06