From: Bart Trojanowski Date: Wed, 21 Feb 2007 08:54:22 GMT Subject: Re: [PATCH 1.5.0.1.37] fix git-remote inconsistent about use of dots in remote names Message-ID: <20070221085422.GF23952@jukie.net> In-Reply-To: <20070221083042.GE23952@jukie.net> After testing some more I noticed that I broke git-remote show. > --- a/git-remote.perl > +++ b/git-remote.perl > @@ -67,7 +67,7 @@ sub list_remote { > $git->command(qw(config --get-regexp), '^remote\.'); > }; > for (@remotes) { > - if (/^remote\.([^.]*)\.(\S*)\s+(.*)$/) { > + if (/^remote\.(.+)\.url\s+(.*)$/) { The patch bellow seems to be better. -Bart >From 9cb44ff2d1d395491cde8c3d5787b35c93c4ad12 Mon Sep 17 00:00:00 2001 From: Bart Trojanowski Date: Wed, 21 Feb 2007 03:54:17 -0500 Subject: [PATCH] allow git-remote to parse out names with periods in them Signed-off-by: Bart Trojanowski --- git-remote.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-remote.perl b/git-remote.perl index 6e473ec..6087a9d 100755 --- a/git-remote.perl +++ b/git-remote.perl @@ -67,7 +67,7 @@ sub list_remote { $git->command(qw(config --get-regexp), '^remote\.'); }; for (@remotes) { - if (/^remote\.([^.]*)\.(\S*)\s+(.*)$/) { + if (/^remote\.(.+)\.([^.]+)\s+(.*)$/) { add_remote_config(\%seen, $1, $2, $3); } } -- 1.5.0.1.37.g1e592-dirty