From: Shawn O. Pearce Date: Thu, 01 Feb 2007 20:59:34 GMT Subject: Re: git repack -a -d is not safe Message-ID: <20070201205934.GA19057@spearce.org> In-Reply-To: <20070201112545.GA19855@moooo.ath.cx> Matthias Lederhofer wrote: > First the object is unpacked, start something using read_sha1_file. > read_sha1_file: try packed object (fails) > run git repack -a -d > read_sha1_file: try to read the loose object (fails) > read_sha1_file: reread list of packs > run git repack -a -d so it will create a new pack > read_sha1_file: tries to open the old packs, not the new one, and > fails My 4 patch series that I just posted should (partially) fix this problem. We cannot close it completely however as there always exists the potential of the OS to starve the reader and allow 2 full repacks between the time the reader notices a .idx file and the time the reader could open the .pack. At least now with my additional changes Git will report that a packfile is not usable, and then that the object cannot be found, and die. All I can say is, wait at least a few minutes between repacks? ;-) -- Shawn.