From: Horst H. von Brand Date: Thu, 25 Jan 2007 18:56:08 GMT Subject: Re: [PATCH] Hash name is SHA-1 Message-ID: <200701251856.l0PIu8pP032403@laptop13.inf.utfsm.cl> In-Reply-To: Nicolas Pitre wrote: > On Thu, 25 Jan 2007, Shawn O. Pearce wrote: > > "Horst H. von Brand" wrote: > > > index 3fefdac..814f78f 100644 > > > --- a/builtin-apply.c > > > +++ b/builtin-apply.c > > > @@ -1811,7 +1812,8 @@ static int apply_binary(struct buffer_desc *desc, struct patch *patch) > > > "without full index line", name); > > > > > > if (patch->old_name) { > > > - /* See if the old one matches what the patch > > > + /* > > > + * See if the old one matches what the patch > > > * applies to. > > > */ > > > hash_sha1_file(desc->buffer, desc->size, blob_type, sha1); > > > > However I cannot help but feel that this hunk is unrelated to the > > theme of this extremely large patch. I don't know how Junio feels, > > but this late in the 1.5.0 series I'm a little leary of a 1600+ > > line patch which is changing so much code, even if its something > > as trivial as the above hunk. > Maybe the patch could be restricted to documentation fixes only for now? That's what I tried to do. But just changing the documentation without changing (some) of the messages and so on just gets you worse inconsistency. -- Dr. Horst H. von Brand User #22616 counter.li.org Departamento de Informatica Fono: +56 32 2654431 Universidad Tecnica Federico Santa Maria +56 32 2654239 Casilla 110-V, Valparaiso, Chile Fax: +56 32 2797513