From: Petr Baudis <pasky@suse.cz>
Date: Mon, 22 Jan 2007 15:44:29 GMT
Subject: Re: [PATCH] Insert ACTIVESTATE_STRING in Git.pm
Message-ID: <20070122154429.GG18276@pasky.or.cz>
In-Reply-To: <81b0412b0701220632t50ad42c4ucb0ebae140a9706a@mail.gmail.com>

On Mon, Jan 22, 2007 at 03:32:28PM CET, Alex Riesen wrote:
> Also add "git" to the pipe parameters, otherwise it does not work at all, as
> no git commands are usable out of git context.
> 
> ---
> 
> This is not enough to make it work on ActiveState. It's just to
> fix obvious TODOs, which should help someone to get it going.
> The other problems are:
> - tie refuses to bind a handle class activestate_pipe to a scalar $fh
>   (a patch follows)
> - there are some unexplained warnings about uninitialized values
> - cygwin-windows pathname conversion (not fixable at all)
> 
> perl/Git.pm |    7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)

Cool.

Acked-by: Petr Baudis <pasky@suse.cz>

Perhaps ACPIPE could use some comment in the code but that's just vain
nitpicking.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
The meaning of Stonehenge in Traflamadorian, when viewed from above, is:
"Replacement part being rushed with all possible speed."
		-- Kurt Vonnegut, Sirens from Titan