From: Shawn O. Pearce Date: Thu, 18 Jan 2007 08:06:13 GMT Subject: Re: [PATCH/POLL] git-format-patch: the default suffix is now .patch, not .txt Message-ID: <20070118080613.GE23124@spearce.org> In-Reply-To: <81b0412b0701172359y1ef4f936pcdcb2de53d6bd468@mail.gmail.com> Alex Riesen wrote: > Also, how many mail clients know that .patch is actually > a text and not application/binary? It'll make patch > reviewing harder for some (not sure if I'd like a review > of such a person, though). Patches intended for review should be sent inline, not attached. Thus the file extension has no impact on how the mail client should treat it. Don't count people out just because they cannot read a *.patch file All constructive feedback is valuable, no matter its source. Of course I did qualify that with "constructive"... ;-) -- Shawn.