From: Alex Riesen <fork0@t-online.de>
Date: Sun, 14 Jan 2007 19:25:57 GMT
Subject: Re: [PATCH] Reencode committer info to utf-8 before formatting mail header
Message-ID: <20070114192557.GA2378@steel.home>
In-Reply-To: <200701140042.l0E0gvMT005024@laptop13.inf.utfsm.cl>

Horst H. von Brand, Sun, Jan 14, 2007 01:42:57 +0100:
> Alex Riesen <fork0@t-online.de> wrote:
> > Junio C Hamano, Sat, Jan 13, 2007 02:31:35 +0100:
> > > +/* High bit set, or ISO-2022-INT */
> > > +static int non_ascii(int ch)
> > > +{
> > > +	ch = (ch & 0xff);
> > > +	return ((ch & 0x80) || (ch == 0x1b));
> > > +}
> > > +
> > 
> > "return (ch & 0x0x80) || (ch & 0xff) == 0x1b;" :)
>                 ^^

Oops :)

> Is the same, if ch == 0x9b, it will match the first part anyway.

So it should. 0x9b isn't ASCII.

> The outer parentesis can (should?) go.

It's "question of style", I'm afraid :)