From: Horst H. von Brand <vonbrand@inf.utfsm.cl>
Date: Sun, 14 Jan 2007 00:42:57 GMT
Subject: Re: [PATCH] Reencode committer info to utf-8 before formatting mail header
Message-ID: <200701140042.l0E0gvMT005024@laptop13.inf.utfsm.cl>
In-Reply-To: <20070113110238.GA2795@steel.home>

Alex Riesen <fork0@t-online.de> wrote:
> Junio C Hamano, Sat, Jan 13, 2007 02:31:35 +0100:
> > +/* High bit set, or ISO-2022-INT */
> > +static int non_ascii(int ch)
> > +{
> > +	ch = (ch & 0xff);
> > +	return ((ch & 0x80) || (ch == 0x1b));
> > +}
> > +
> 
> "return (ch & 0x0x80) || (ch & 0xff) == 0x1b;" :)
                ^^

Is the same, if ch == 0x9b, it will match the first part anyway.

The outer parentesis can (should?) go.
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513