From: Shawn O. Pearce Date: Mon, 01 Jan 2007 20:57:43 GMT Subject: Re: [PATCH 3/4] Automatically detect a bare git repository. Message-ID: <20070101205743.GA26821@spearce.org> In-Reply-To: <20061231175407.GC6115@admingilde.org> Martin Waitz wrote: > On Sat, Dec 30, 2006 at 11:30:19PM -0500, Shawn O. Pearce wrote: > > We test the current working directory only after we have tried > > searching up the directory tree. This is to retain backwards > > compatibility with our previous behavior on the off chance that > > a user has a 'refs' and 'objects' subdirectories and a 'HEAD' > > file that looks like a symref, all stored within a repository's > > associated working directory. > > Hmm, I have my dot files under GIT control so I can't use this mechanism > to use bare GIT repositories under ~/git/*.git. Whoops. I assume you have your .gitignore populated with the other files/directories in your home directory that shouldn't be under Git control? > Perhaps we should test the current directory first, but check that it > ends in .git? Junio already stated why that may not be a good idea. My original version of the patch did check the current directory first, but it could match a working directory which isn't really a Git repository but just looks sort of like one. That wouldn't be backwards compatible, so I moved the current directory check to just before failure. That version is the one that I submitted, and that Junio accepted... -- Shawn.