From: Shawn Pearce Date: Wed, 27 Dec 2006 08:33:28 GMT Subject: Re: [PATCH] Create 'git gc' to perform common maintenance operations. Message-ID: <20061227083328.GD23022@spearce.org> In-Reply-To: <7vhcvh922r.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > Shawn Pearce writes: > > > I don't care either way. 60 days may be too long for some users, > > but for others it may be nice to have. I think the two defaults > > should match just because. Feel free to edit my patch before > > applying to be whatever 'git-reflog expire' uses if you want. > > I think the built-in git-reflog should be updated to honor the > configuration in the absense of command line options; if we do > that git-gc.sh does not even have to call repo-config anymore. Sure, but then maybe the configuration options shouldn't be 'gc.reflog*' but instead 'reflog.*'. git-gc.sh was a quick hack while I was waiting for that huge disk IO to repack a git.git with 1.3.3. I was trying to avoid hacking C code for it, but you are probably right, better to just make the C code do the right thing from "day one". -- Shawn.