From: Shawn O. Pearce Date: Sat, 23 Dec 2006 07:34:38 GMT Subject: [PATCH 13/17] Ensure core.packedGitWindowSize cannot be less than 2 pages. Message-ID: <20061223073438.GN9837@spearce.org> In-Reply-To: <53b67707929c7f051f6d384c5d96e653bfa8419c.1166857884.git.spearce@spearce.org> We cannot allow a window to be smaller than 2 system pages. This limitation is necessary to support the feature of use_pack() where we always supply at least 20 bytes after the offset to help the object header and delta base parsing routines. If packedGitWindowSize were allowed to be as small as 1 system page then we would be completely unable to access an object header which spanned over a page as we would never be able to arrange a mapping such that the header was contiguous in virtual memory. Signed-off-by: Shawn O. Pearce --- config.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config.c b/config.c index a8ea063..edc42f4 100644 --- a/config.c +++ b/config.c @@ -302,8 +302,8 @@ int git_default_config(const char *var, const char *value) int pgsz = getpagesize(); packed_git_window_size = git_config_int(var, value); packed_git_window_size /= pgsz; - if (!packed_git_window_size) - packed_git_window_size = 1; + if (packed_git_window_size < 2) + packed_git_window_size = 2; packed_git_window_size *= pgsz; return 0; } -- 1.4.4.3.g87d8