From: Jeff King <peff@peff.net>
Date: Mon, 18 Dec 2006 22:45:05 GMT
Subject: Re: [PATCH] git-parse-remote: fix ambiguous shell bug in expand_refs_wildcard
Message-ID: <20061218224505.GB13034@coredump.intra.peff.net>
In-Reply-To: <7v4prtx9hu.fsf@assigned-by-dhcp.cox.net>

On Mon, Dec 18, 2006 at 11:57:33AM -0800, Junio C Hamano wrote:

> Sounds like a dash bug, if my reading of 2.6.2 Parameter
> Expansion is correct:
> 
>     http://www.opengroup.org/onlinepubs/000095399/utilities/xcu_chap02.html

Interestingly, this works in dash:

$ foo=bar}
$ echo ${foo%'}'}
bar

but doing it inside an interpolated string doesn't:

$ foo=bar}
$ echo "${foo%'}'}"
bar}'}

> This would be another way to work it around.  Both dash and bash
> say 'foo':
> 
>         $ suf='^{}'
>         $ name='foo^{}'
>         $ echo "${name%$suf}"
>         foo
> 
> I think this might be easier to read than using "^{\}".

That seems reasonable to me.