From: Shawn Pearce Date: Thu, 14 Dec 2006 12:13:36 GMT Subject: Re: [PATCH 1/1] Bypass expensive content comparsion during rename detection Message-ID: <20061214121336.GN1747@spearce.org> In-Reply-To: <200612141126.kBEBQme7021704@hera.kernel.org> Junio C Hamano wrote: > estimate_similarity() is called after it has determined that one > and two do not match exactly, and it relies on populate_filespec > with at least size-only has been called on them so that it can > reject filepair with vastly different sizes, still without > looking at (thus without loading) the contents. *ouch* That hurts. OK, it makes a lot of sense, but its crazy. About as crazy as the comment I put in my revised patch... ;-) --