From: Sasha Khapyorsky Date: Thu, 14 Dec 2006 02:21:42 GMT Subject: Re: git-svnimport breakage as of git-1.4.4 Message-ID: <20061214022142.GA14521@sashak.voltaire.com> In-Reply-To: <1166027289.21948.4.camel@systems03.lan.brontes3d.com> On 11:28 Wed 13 Dec , Daniel Drake wrote: > > Sorry, apparently I was using the wrong git-svnimport in my last mail. > The above command, with or without your svn_dir patch, doesn't solve the > problem. > > With your patch: Original patch is wrong, so only w/out this patch. > > # git-svnimport -v -i -C repo -r https://server/repo > > RA layer request failed: PROPFIND request failed on '/trunk/.cvsignore': > PROPFIND of '/trunk/.cvsignore': 405 Method Not Allowed (https://svn) at > git-svnimport line 364 > > Without the patch, the error is the same as the 1st case in both > situations. Try this please: diff --git a/git-svnimport.perl b/git-svnimport.perl index cbaa8ab..071777b 100755 --- a/git-svnimport.perl +++ b/git-svnimport.perl @@ -146,6 +146,7 @@ sub file { print "... $rev $path ...\n" if $opt_v; my (undef, $properties); my $pool = SVN::Pool->new(); + $path =~ s#^/*##; eval { (undef, $properties) = $self->{'svn'}->get_file($path,$rev,$fh,$pool); }; $pool->clear; @@ -181,6 +182,7 @@ sub ignore { my($self,$path,$rev) = @_; print "... $rev $path ...\n" if $opt_v; + $path =~ s#^/*##; my (undef,undef,$properties) = $self->{'svn'}->get_dir($path,$rev,undef); if (exists $properties->{'svn:ignore'}) { @@ -197,6 +199,7 @@ sub ignore { sub dir_list { my($self,$path,$rev) = @_; + $path =~ s#^/*##; my ($dirents,undef,$properties) = $self->{'svn'}->get_dir($path,$rev,undef); return $dirents; @@ -354,6 +357,7 @@ open BRANCHES,">>", "$git_dir/svn2git"; sub node_kind($$) { my ($svnpath, $revision) = @_; my $pool=SVN::Pool->new; + $svnpath =~ s#^/*##; my $kind = $svn->{'svn'}->check_path($svnpath,$revision,$pool); $pool->clear; return $kind; Thanks,