From: Alex Riesen <fork0@t-online.de>
Date: Sat, 09 Dec 2006 01:16:39 GMT
Subject: Re: [PATCH] Allow building GIT in a different directory from the source directory
Message-ID: <20061209011639.GA8010@steel.home>
In-Reply-To: <elc6j2$vej$1@sea.gmane.org>

Han-Wen Nienhuys, Fri, Dec 08, 2006 18:15:25 +0100:
> -my %pm = ('Git.pm' => '$(INST_LIBDIR)/Git.pm');
> +
> +$src_prefix = '';
> +if (!($ENV{'PERL_SRCDIR'} eq "")) {
> +    $src_prefix = $ENV{'PERL_SRCDIR'} . "/"
> +}

Hurts my eyes :)

    $src_prefix = defined($ENV{PERL_SRCDIR}) ?  "$ENV{PERL_SRCDIR}/": '';

could be shorter, unless you want (you do) strict syntax check.