From: Jakub Narebski <jnareb@gmail.com>
Date: Sat, 25 Nov 2006 11:08:00 GMT
Subject: Re: [PATCH (take 3)] gitweb: Use git-show-ref instead of git-peek-remote
Message-ID: <200611251208.01047.jnareb@gmail.com>
In-Reply-To: <7v7ixj3izw.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> While at it make git_get_references return hash in list context,
>> and reference to hash (as it used to do) in scalar and void contexts.
> 
> Why did you have to add this?  Generally, context sensitive
> returns make the program much harder to maintain, because it
> forces the call sites to be extremely careful to choose between
> "my ($foo) = func()" vs "my $foo = func()", and people who later
> call the function inevitably make mistakes.
> 
> So unless there is a compelling reason, I'd rather not see more
> "wantarray" in the program.

O.K. I have browsed through gitweb, and I see that we almost always
want the hashref, not hash (for passing further).

-- 
Jakub Narebski