From: Robin Rosenberg Date: Tue, 14 Nov 2006 06:49:04 GMT Subject: Re: [PATCH] Rework cvsexportcommit to handle binary files for all cases. Message-ID: <200611140749.05023.robin.rosenberg@dewire.com> In-Reply-To: <7vveli4zxc.fsf@assigned-by-dhcp.cox.net> tisdag 14 november 2006 01:47 skrev Junio C Hamano: >Robin Rosenberg wrote: >> I sent a patch earlier, which was not applied, due to imperfections that I >> cannot solve fully. One issue was that patch 2.5.9 was required and hacking >> it to handle binary diffs with spaces would require and even worse kludge, > >I suspect that we should not be using patch, but instead be >using git-apply perhaps with -C option if people want fuzz. Does git-apply work without a git repo? We're applying patches onto a CVS repo. >[...] > I know this script originally came from southern hemisphere, but > I was talking about _western_ hemisphere. The comment refers to > the part of the code the attached patch fixes, which I will > apply along with your updated patch. Western/nothern, both apply to where I live. >[...] >I think scripts that work with git > plumbing should read from -z output when they need to and are > capable of, as we have done for git-cvsserver recently, and > things written in Perl certainly are capable of doing so. I'll investgate that.