From: Jakub Narebski Date: Tue, 07 Nov 2006 00:02:15 GMT Subject: Re: [PATCH 2/n] gitweb: Use '&iquot;' instead of '?' in esc_path Message-ID: <200611070102.15662.jnareb@gmail.com> In-Reply-To: <7vwt68b0f3.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > Jakub Narebski writes: > >> Junio C Hamano wrote: >> >>> Jakub Narebski writes: >>> >>>> Here is example code for this: >>> >>> Ok. The issues I raised in the previous round seem to have been >>> addressed. Maybe you would want not to use nested 'sub' and it >>> is good to go, I think. >> >> Nested sub makes it easy to change gitweb quoting from Character Escape >> Codes (CEC) to e.g. Unicode Printable Representation (PR). > > Yes, sub makes it easy, it is not needed to be nested. Well, this sub is of no use (I think) ourside esc_path subroutine. Similarly for unq sub nested in unescape in PATCH 1/10. -- Jakub Narebski