From: Petr Baudis Date: Fri, 27 Oct 2006 02:05:49 GMT Subject: Re: [PATCH] cogito: Honor either post-commit script name; fail if both are executable Message-ID: <20061027020549.GY20017@pasky.or.cz> In-Reply-To: <874ptzhsjs.fsf@rho.meyering.net> Hi! Dear diary, on Fri, Oct 20, 2006 at 06:15:51PM CEST, I got a letter where Jim Meyering said that... > I promised this patch some time ago, made the changes, > and then never sent them. This is slightly different > from the current implementation in that it fails when both > scripts are executable. Also, it factors out the script names and > adds tests. > > Signed-off-by: Jim Meyering I'm not sure I like this (of course, I always like additional tests, though). The problem is that this loses a smooth upgrade path, things suddenly break and you can't commit without having to think about fixing your environment. We should always give users enough time for that with deprecation warnings. So if we want to get rid of commit-post, we should rather start printing deprecation warnings if commit-post exists, and in few months cut commit-post off. -- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ #!/bin/perl -sp0777i