From: Jakub Narebski Date: Thu, 26 Oct 2006 10:26:44 GMT Subject: [PATCH] gitweb: Check git base URLs before generating URL from it Message-ID: <200610261226.44960.jnareb@gmail.com> Check if each of git base URLs in @git_base_url_list is true before appending "/$project" to it to generate project URL. This fixes the error that for default configuration for gitweb in Makefile, with GITWEB_BASE_URL empty (and "++GITWEB_BASE_URL++" being "" in gitweb.cgi), we had URL of "/$project" in the summary view. Signed-off-by: Jakub Narebski --- I don't think that anybody would want base URL of "0". gitweb/gitweb.perl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 35a9afb..0d2ea72 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -2516,7 +2516,8 @@ sub git_summary { # or make project git URL from git base URL and project name my $url_tag = "URL"; my @url_list = git_get_project_url_list($project); - @url_list = map { "$_/$project" } @git_base_url_list unless @url_list; + @url_list = map { $_ ? "$_/$project" : () } + @git_base_url_list unless @url_list; foreach my $git_url (@url_list) { next unless $git_url; print "$url_tag$git_url\n"; -- 1.4.3.3