From: Shawn Pearce <spearce@spearce.org>
Date: Mon, 23 Oct 2006 21:55:06 GMT
Subject: Re: [PATCH] Make git-branch a builtin
Message-ID: <20061023215506.GB8344@spearce.org>
In-Reply-To: <11616396262982-git-send-email-hjemli@gmail.com>

Lars Hjemli <hjemli@gmail.com> wrote:
[snip]
> ---
>  Makefile         |    3 +-
>  builtin-branch.c |  217 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  builtin.h        |    1 +
>  git-branch.sh    |  131 --------------------------------
>  git.c            |    1 +
>  5 files changed, 221 insertions(+), 132 deletions(-)
[snip]
> diff --git a/git-branch.sh b/git-branch.sh
> deleted file mode 100755
> index 4379a07..0000000
> --- a/git-branch.sh
> +++ /dev/null
> @@ -1,131 +0,0 @@
[snip 131 lines]

Aside from compatability with non-Git tools...

Wouldn't it make more sense to just include the full SHA1 of the
file we are deleting rather than the entire 131 line negative diff?

-- 
Shawn.