From: Jakub Narebski Date: Mon, 09 Oct 2006 09:26:16 GMT Subject: Re: [PATCH] gitweb: Cleanup Git logo and Git logo target generation Message-ID: <200610091126.17055.jnareb@gmail.com> In-Reply-To: <7vvemtdfst.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > Jakub Narebski writes: > > > Partial improvement is better than no improvement. > > Not necessarily. As the maintainer, I found that when we say > "we will fix it later", later tend to never come, and one > effective way to fight that tendency is to prod the contributors > a bit harder, which worked reasonably well so far. Well. Perhaps. But first, it is also bugfix for esc_html on URL, and second I though you rather have one feature per patch; this one has two - cleanup of logo generation, and moving style to CSS. "Better" patch would have three... -- Jakub Narebski Poland