From: Luben Tuikov Date: Sat, 07 Oct 2006 18:52:53 GMT Subject: Re: [PATCH 1/2] gitweb: Show snapshot links for tree entries in tree listing Message-ID: <20061007185253.90045.qmail@web31810.mail.mud.yahoo.com> In-Reply-To: <20061007184148.GE20017@pasky.or.cz> --- Petr Baudis wrote: > Dear diary, on Sat, Oct 07, 2006 at 08:37:02PM CEST, I got a letter > where Luben Tuikov said that... > > --- Petr Baudis wrote: > > > Currently that's inconsistently reachable only by first displaying the > > > tree. > > > > I cannot say that there is any "inconsistency" there per se. I also > > fail to see the value of this patch. > > Currently the bottom navbar is more or less the same as the list of > links in the tree entry (there's the HEAD link but that's a special > case). I completely understand where you're coming from. I do. But this patch makes the view so much more cluttered. And it isn't vital. Yes we can do it, yes gitweb can do it, but I doubt the core value. Another thing is that currently tree/directory entries' third (links) column to be shortest of all, and this gives my eyes another indication that this is a tree. Imagine a long list of files, and in the middle a directory. Then you'd see only the "history" link next to it, as opposed to the long "history | snapshot"... I'm ambivalent as to whether this goes in or not. If the people want it, so be it. Luben > > -- > Petr "Pasky" Baudis > Stuff: http://pasky.or.cz/ > #!/bin/perl -sp0777i $/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1 > lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/) > - > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >