From: Luben Tuikov <ltuikov@yahoo.com>
Date: Fri, 06 Oct 2006 22:16:03 GMT
Subject: Re: [PATCH] gitweb: Do not print "log" and "shortlog" redundantly in commit view
Message-ID: <20061006221603.50873.qmail@web31815.mail.mud.yahoo.com>
In-Reply-To: <eg51fi$7rs$2@sea.gmane.org>

--- Jakub Narebski <jnareb@gmail.com> wrote:
> Gaah, the whole cae1862a3b55b487731e9857f2213ac59d5646d commit
> "gitweb: More per-view navigation bar links" is somewhat broken.
> Up to this point we used top navigation bar for commit (hash base)
> or whole project related links, while bottom part of navigation
> bar for "formats" i.e. links related to current view (passing hash)
> or for pagination.
> 
> So while "snapshot" link has it's place in top navigation bar
> (but by modyfying git_print_page_nav subroutine, not by adding it
> by hand), "history" for example IMHO doesn't; history link should be
> present in the bottom part of navigation bar. Perhaps we could
> reuse git_print_page_nav for formats, for example blob wiew would have
>         blob | _blame_ | _history_ | _raw_ | _HEAD_
> while tree view would have
>         tree | _snapshot_ | _history_ | _HEAD_
> (where _text_ indices link).  Perhaps _snapshot_ in tree view
> shouldn't be repeated, although top one might mean snapshot of commitish,
> bottom one snapshot of tree.

Only a single one: of committish please.

    Luben