From: Luben Tuikov <ltuikov@yahoo.com>
Date: Thu, 28 Sep 2006 23:27:52 GMT
Subject: Re: gitweb: using quotemeta
Message-ID: <20060928232752.99373.qmail@web31804.mail.mud.yahoo.com>
In-Reply-To: <7vodszshq3.fsf@assigned-by-dhcp.cox.net>

--- Junio C Hamano <junkio@cox.net> wrote:
> 
> Ouch, that was a sloppy planning and coding, and sloppier
> reviewing.  Sorry.
> 
> What is the right quoting there?  Just quoting double-quotes?

I'm not sure.  What undesired character could we have in $filename
of a snapshot?  The commit ab41dfbfd4f message gives this
justification: "Just in case filename contains end of line character."

It looks like $filename is constructed by well defined strings:
basename($project), $hash and $suffix all of which should be ok.

I'd say we don't need quotemeta for $filename of snapshot.

    Luben